Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for -ll:networks none, we will init MPI if it has not been initialized #465

Merged
merged 4 commits into from
Nov 7, 2022

Conversation

eddy16112
Copy link

If -ll:networks none is passed, then GASNet will not be initialized, in this case, we will init the MPI explicitly.

@eddy16112 eddy16112 added the category:bug-fix PR is a bug fix and will be classified as such in release notes label Nov 4, 2022
@eddy16112 eddy16112 requested a review from manopapad November 4, 2022 09:32
@manopapad
Copy link
Contributor

If -ll:networks is none, that means we're not running in multi-rank/multi-node mode, therefore there's only one node. In that case we shouldn't need to initialize the MPI communicator in the first place. Is that right?

@manopapad
Copy link
Contributor

OK, I see what's happening. Currently we decide whether we'll be using the MPI communicator at compile time, based on whether Realm was compiled with a network. However, now it's possible that Realm is compiled with a networking backend, but that backend is not loaded at runtime.

@magnatelee
Copy link
Contributor

I think the right course of action when no network is given is to activate the pthread-based communicator, not initializing the MPI one. A prerequisite is, as Manolis said, being able to query the chosen network module in a programmable way.

@manopapad
Copy link
Contributor

Is this deprecated by #468?

@eddy16112
Copy link
Author

Is this deprecated by #468?

Not necessary. With this one. the QA team can start testing, but that one requires more time/work to be merged.

@eddy16112 eddy16112 merged commit 1ec34b4 into nv-legate:branch-22.12 Nov 7, 2022
@eddy16112 eddy16112 deleted the fix_networks branch November 29, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:bug-fix PR is a bug fix and will be classified as such in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants