Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

legate/core: fix FutureMap leak in communicator shutdown #495

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

rohany
Copy link
Member

@rohany rohany commented Nov 23, 2022

This commit fixes the following leak, leading to shutdown hangs.

found cycle!
  tail:
    0x200092ca1e10: <class 'legate.core._legion.future.FutureMap'>
     ^
    0x200058dd65c0: <class 'dict'>
     ^ ["_handles"]
    0x2000588dff80: <class 'dict'>
     ^ .__dict__
    0x2000889b11b0: <class 'legate.core.communicator.NCCLCommunicator'>
     ^ ["_nccl"]
    0x2000588dd540: <class 'dict'>
     ^ .__dict__
    0x2000887b8430: <class 'legate.core.runtime.CommunicatorManager'>
     ^ ["_comm_manager"]
    0x2000889f7d00: <class 'dict'>
     ^ .__dict__
    0x2000887b9f90: <class 'legate.core.runtime.Runtime'>
     ^ ["runtime"]
    0x200173d7b180: <class 'dict'>
  cycle:
    0x200173d7b180: <class 'dict'>
     ^ .__dict__
    0x200173d84370: <class 'legate.core.runtime.ConsensusMatchingFieldManager'>
     ^ ["manager"]
    0x200173e30cc0: <class 'dict'>
     ^ .__dict__
    0x200173db2e00: <class 'legate.core.runtime.FreeFieldInfo'>
     ^ [85]
    0x200173df0f80: <class 'list'>
     ^ ["_freed_fields"]
    0x2000588ddb40: <class 'dict'>
     ^ .__dict__
    0x2000889b0fa0: <class 'legate.core.runtime.FieldMatchManager'>
     ^ ["_field_match_manager"]
    0x200173d7b180: <class 'dict'>

Signed-off-by: Rohan Yadav rohany@alumni.cmu.edu

This commit fixes the following leak, leading to shutdown hangs.

```
found cycle!
  tail:
    0x200092ca1e10: <class 'legate.core._legion.future.FutureMap'>
     ^
    0x200058dd65c0: <class 'dict'>
     ^ ["_handles"]
    0x2000588dff80: <class 'dict'>
     ^ .__dict__
    0x2000889b11b0: <class 'legate.core.communicator.NCCLCommunicator'>
     ^ ["_nccl"]
    0x2000588dd540: <class 'dict'>
     ^ .__dict__
    0x2000887b8430: <class 'legate.core.runtime.CommunicatorManager'>
     ^ ["_comm_manager"]
    0x2000889f7d00: <class 'dict'>
     ^ .__dict__
    0x2000887b9f90: <class 'legate.core.runtime.Runtime'>
     ^ ["runtime"]
    0x200173d7b180: <class 'dict'>
  cycle:
    0x200173d7b180: <class 'dict'>
     ^ .__dict__
    0x200173d84370: <class 'legate.core.runtime.ConsensusMatchingFieldManager'>
     ^ ["manager"]
    0x200173e30cc0: <class 'dict'>
     ^ .__dict__
    0x200173db2e00: <class 'legate.core.runtime.FreeFieldInfo'>
     ^ [85]
    0x200173df0f80: <class 'list'>
     ^ ["_freed_fields"]
    0x2000588ddb40: <class 'dict'>
     ^ .__dict__
    0x2000889b0fa0: <class 'legate.core.runtime.FieldMatchManager'>
     ^ ["_field_match_manager"]
    0x200173d7b180: <class 'dict'>
```

Signed-off-by: Rohan Yadav <rohany@alumni.cmu.edu>
@rohany rohany added the category:bug-fix PR is a bug fix and will be classified as such in release notes label Nov 23, 2022
@rohany rohany merged commit 91a2ff8 into nv-legate:branch-22.12 Nov 23, 2022
manopapad added a commit that referenced this pull request Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:bug-fix PR is a bug fix and will be classified as such in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants