Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nvml dependency in the conda build script to get the headers for realm #586

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Conversation

m3vaz
Copy link

@m3vaz m3vaz commented Feb 23, 2023

While trying to debug the CI, my local build hit the following from legion/realm compilation:

[35/197] Building CXX object _deps/legion-build/runtime/CMakeFiles/RealmRuntime.dir/realm/cuda/cuda_module.cc.o
FAILED: _deps/legion-build/runtime/CMakeFiles/RealmRuntime.dir/realm/cuda/cuda_module.cc.o
$BUILD_PREFIX/bin/x86_64-conda-linux-gnu-c++ -DRealmRuntime_EXPORTS -I$PREFIX/include -I$SRC_DIR/build/_deps/legion-src/runtime -I$SRC_DIR/build/_deps/legion-build/runtime -UNDEBUG -march=haswell -O2 -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -Woverloaded-virtual -std=gnu++17 -MD -MT _deps/legion-build/runtime/CMakeFiles/RealmRuntime.dir/realm/cuda/cuda_module.cc.o -MF _deps/legion-build/runtime/CMakeFiles/RealmRuntime.dir/realm/cuda/cuda_module.cc.o.d -o _deps/legion-build/runtime/CMakeFiles/RealmRuntime.dir/realm/cuda/cuda_module.cc.o -c $SRC_DIR/build/_deps/legion-src/runtime/realm/cuda/cuda_module.cc
In file included from $SRC_DIR/build/_deps/legion-src/runtime/realm/cuda/cuda_module.cc:17:
$SRC_DIR/build/_deps/legion-src/runtime/realm/cuda/cuda_internal.h:23:10: fatal error: nvml.h: No such file or directory
   23 | #include <nvml.h>
      |          ^~~~~~~~
compilation terminated.

I'm not sure when realm began depending on nvml. Adding the necessary dependency linkage resulted in a successful build locally.

@m3vaz m3vaz added the category:bug-fix PR is a bug fix and will be classified as such in release notes label Feb 23, 2023
@manopapad manopapad merged commit 8fc4440 into nv-legate:branch-23.03 Feb 23, 2023
manopapad pushed a commit that referenced this pull request Mar 5, 2025
When UCX is enabled, ensure that we actually build the package with UCX support.

Also decrease the amount of workers when testing UCX packages to work around #635.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:bug-fix PR is a bug fix and will be classified as such in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants