Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Legion to specific commit sha by default #593

Merged
merged 10 commits into from
Mar 6, 2023

Conversation

trxcllnt
Copy link

This PR pins the Legion repo URL and git revision that's built if Legion is not found via find_package().

It explicitly ignores values stored in the CMakeCache.txt, so subsequent rebuilds that don't set the --legion-{url,branch} args revert to the defaults:

$ install.py --editable --legion-branch "feature_branch"

# Reverts to building the default pinned Legion sha, not "feature_branch"
$ install.py --editable

@trxcllnt trxcllnt added the category:improvement PR introduces an improvement and will be classified as such in release notes label Feb 28, 2023
@marcinz
Copy link
Collaborator

marcinz commented Feb 28, 2023

Is it possible to move the SHA for Legion to versions.json? I think we discussed it at some point, but I wonder how hard it is.

@magnatelee
Copy link
Contributor

Is it possible to move the SHA for Legion to versions.json?

+1

@trxcllnt
Copy link
Author

Yes, that's possible.

@manopapad manopapad merged commit 21f1416 into nv-legate:branch-23.03 Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:improvement PR introduces an improvement and will be classified as such in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants