More robust nsys --sample flag with --nsys-extra #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjwilke
added
the
category:bug-fix
bryevdv
approved these changes
Mar 10, 2023
|
@bryevdv PTAL. I added tests and made the checks more robust. |
bryevdv
reviewed
Mar 17, 2023
bryevdv
reviewed
Mar 17, 2023
manopapad
reviewed
Mar 20, 2023
|
|
||
| if nsys_parsed_args.targets: | ||
| raise RuntimeError( | ||
| "please pass targets as arguments to --nsys" |
There was a problem hiding this comment.
Suggested change
| "please pass targets as arguments to --nsys" | |
| "please pass targets through --nsys-targets" |
manopapad
approved these changes
Mar 20, 2023
manopapad
pushed a commit
that referenced
this pull request
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current nsys flag only checks for
-sto deduplicate. The user might pass any of the following:The user will get a cryptic error about --sample being passed twice unless they use
-s <>