Fix example build tests #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjwilke
commented
Mar 27, 2023
•
jjwilke
commented
- Example rules were not target-specific, which lead to name clashes when building the examples in-tree
- SKBUILD paths did not set the correct Legate root
- Adds flag to install.py for building examples
jjwilke
added
the
category:bug-fix
magnatelee
approved these changes
Mar 27, 2023
manopapad
pushed a commit
that referenced
this pull request
Mar 5, 2025
* Minor miscelaneous fixups * static assert that references are references * Use optional instead of unique_ptr for Runtime * minor type_info fixes * eradicate const std::string& in favor of std::string_view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.