Use parent frame indiscriminately in nested provenance #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manopapad
added
the
category:improvement
bryevdv
reviewed
Apr 10, 2023
Co-authored-by: Bryan Van de Ven <bryan@bokeh.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, even if all nested calls to provenance-tracking functions are recorded, each level will record the same provenance string (*), since they all go all the way up to the first user-level frame. With this change, each time we record provenance we simply use the frame which called into the tracked function. This should be equivalent to the current behavior in cases where nesting is disabled, but should allow us to better track intra-library recursive calls if we want to.
Eventually we will want to be recording all the levels of nesting, in the machine-readable part of the provenance, not just the top or bottom.
(*) Technically if the calls switch between libraries, the stack walking will stop at each library switch, but that doesn't help if we're trying to track recursive calls within the same library.