Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CMake template directories to use current_dir for subfolders #688

Merged
merged 2 commits into from
Apr 20, 2023

Conversation

jjwilke
Copy link

@jjwilke jjwilke commented Apr 14, 2023

No description provided.

@jjwilke jjwilke requested review from manopapad and magnatelee April 14, 2023 21:02
@magnatelee magnatelee added the category:bug-fix PR is a bug fix and will be classified as such in release notes label Apr 14, 2023
Copy link
Contributor

@manopapad manopapad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That fixes my issue. Now the file is under

tests/integration/registry/registry/install_info.py

That still gets included in git untracked files. Might I suggest changing .gitignore from just legate/install_info.py to any install_info.py in general?

@jjwilke jjwilke merged commit 687df12 into nv-legate:branch-23.05 Apr 20, 2023
manopapad pushed a commit that referenced this pull request Mar 5, 2025
* Move FutureWrapper to its own file and clean up slightly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:bug-fix PR is a bug fix and will be classified as such in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants