Revise CMAKE helper functions to support custom Python paths. #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manopapad
added
the
category:improvement
|
@manopapad I think something went wrong with the |
@csadorf we require that every PR have one of the "category" labels, to generate the release notes automatically later. |
jjwilke
approved these changes
May 3, 2023
cmake/legate_helper_functions.cmake
Outdated
| elseif(IS_ABSOLUTE LEGATE_OPT_PY_PATH) | ||
| set(py_path "${LEGATE_OPT_PY_PATH}") | ||
| else() | ||
| set(py_path "${CMAKE_SOURCE_DIR}/${LEGATE_OPT_PY_PATH}") |
There was a problem hiding this comment.
Should this be CMAKE_SOURCE_DIR or CMAKE_CURRENT_SOURCE_DIR?
There was a problem hiding this comment.
Using CMAKE_CURRENT_SOURCE_DIR is probably more flexible.
|
@jjwilke I addressed your question. |
|
@jjwilke Any chance we could merge this soon? |
jjwilke
approved these changes
May 16, 2023
|
@csadorf Done. Sorry about the delay. |
No worries at all, thank you for merging! |
manopapad
pushed a commit
that referenced
this pull request
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change set enables the support of legate plugin repository structures, where the CPP and Python source code are maintained in different top-level directories and also supports nested Python directories for namespace packages, such as
legate/my_lib.