Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add specialized constructors and safety checks to legate::Scalar #736

Merged
merged 2 commits into from
May 30, 2023
Merged

Add specialized constructors and safety checks to legate::Scalar #736

merged 2 commits into from
May 30, 2023

Conversation

magnatelee
Copy link
Contributor

No description provided.

@magnatelee magnatelee added the category:improvement PR introduces an improvement and will be classified as such in release notes label May 25, 2023
@magnatelee magnatelee requested a review from manopapad May 25, 2023 05:24
manopapad
manopapad approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@manopapad manopapad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 typo otherwise looks good

@magnatelee @manopapad
Update src/core/data/scalar.h
7f6f7be 
Co-authored-by: Manolis Papadakis <manopapad@gmail.com>
@magnatelee magnatelee merged commit fff8f3c into nv-legate:branch-23.07 May 30, 2023
@magnatelee magnatelee deleted the improve-scalar branch May 30, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manopapad manopapad manopapad approved these changes

Assignees
No one assigned
Labels
category:improvement PR introduces an improvement and will be classified as such in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magnatelee @manopapad