Opt-out validation for C++ accessor types and dimension

[RAMitchell]

Check the type and dimension of C++ accessors. Adds a template parameter to optionally disable checking.

In case the type is not primative, check the size of the type.

It would be nice to also do this for reduce accessors, but reduce operators have a LHS and RHS type and I'm not sure if its correct to test one of these types.

[rapids-bot]

Pull requests from external contributors require approval from a nv-legate organization member with write or admin permissions before CI can begin.

[RAMitchell]

I would have liked to write some tests for this, but not sure how in the current organisation of tests.

[jjwilke]

I like the change. Thanks for putting this together.

I think this changes the existing behavior in a way we wouldn't want? Double check me?

[jjwilke]

IIUC, this changes the existing behavior so that even non-debug builds will check the dimension. Previously dim is only checked for DEBUG_LEGATE.

Should we change this so that VALIDATE_TYPE defaults to true for DEBUG_LEGATE and false otherwise?

[magnatelee]

I guess it wouldn't be too bad to turn it on by default even in release mode, as it'd only introduce a couple of checks

[RAMitchell]

It's intended to change behavior to increase type safety. If a type mismatch occurs it seems much more likely to me to be a programmer mistake than intended, hence the opt out instead of opt in behavior.

[jjwilke]

I guess the check should be cheap and only done once per task. I'm fine with the change in existing behavior.

[RAMitchell]

Can this be merged?

[RAMitchell]

Test failures appear unrelated as no python code was changed.

[magnatelee]

@RAMitchell can you rebase this on the latest branch-23.07? I know your changes have nothing to do with those failures, but I want to make sure everything is green after the merge.

[magnatelee]

@RAMitchell looks like all tests are now passing, so feel free to merge this PR. (I believe you're now a member of the group, so you should have permission.)