Add support for --gasnet-system #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryevdv
added
the
category:improvement
manopapad
approved these changes
Jun 9, 2023
bryevdv
force-pushed
the
bv/gasnet-system
branch
from
f4bd45f to
74342d3
Compare
|
rebased to fix some weird cruft/mess-up. Also added commit to use f-strings consistently in |
manopapad
reviewed
Jun 12, 2023
manopapad
approved these changes
Jun 12, 2023
Co-authored-by: Manolis Papadakis <manopapad@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for specifying
--gasnet-systemtoinstall.py. This is useful for some specialized systems such as Perlmutter. I have not had a chance to test this there yet, as Perlmutter is down for maintenance today, but the generatedcmakeinvocations look correct locally.This PR also updates the legion repo commit pin to the latest HEAD of
control_replication