Add support for custom wrappers #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryevdv
added
the
category:improvement
manopapad
approved these changes
Aug 9, 2023
legate/driver/args.py
Outdated
Comment on lines
373
to
374
| "executable) that will be responsible to indirectly invoke legate, " | ||
| "including any other wrappers. May contain the special string " |
There was a problem hiding this comment.
Suggested change
| "executable) that will be responsible to indirectly invoke legate, " | |
| "including any other wrappers. May contain the special string " | |
| "executable) to wrap the Legate executable invocation. This wrapper will " | |
| "come right after the launcher invocation, and will be passed the rest of " | |
| "the Legate invocation (including any other wrappers) to execute. May " | |
| "contain the special string " |
suggested rewording, similar for --wrapper-inner
manopapad
approved these changes
Aug 9, 2023
manopapad
pushed a commit
that referenced
this pull request
Mar 5, 2025
* don't overquote cuda flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new command line options
--wrapperand--wrapper-innerto allow users to insert their own custom wrapper executables int the legate invocation chain.Both wrappers come after
bind.shso that%%LEGATE_GLOBAL_RANK%%can be expanded in the invocation.