Respect the type of passed storage in create_store #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manopapad
added
the
category:bug-fix
bryevdv
reviewed
Sep 13, 2023
legate/core/runtime.py
Outdated
| Future | ||
| type(data) | ||
| if data is not None | ||
| else Future | ||
| if optimize_scalar and shape is not None and shape.volume() == 1 | ||
| else RegionField |
There was a problem hiding this comment.
TBH I'd split this up some way, chained ternaries are a bit awkward for people and for black
legate/core/runtime.py
Outdated
| if ( | ||
| data is not None | ||
| and not isinstance(data, RegionField) | ||
| and not isinstance(data, Future) |
There was a problem hiding this comment.
if data and not isinstance(data, (RegionField, Future))would avoid the black vertical explosion I think
bryevdv
approved these changes
Sep 22, 2023
manopapad
pushed a commit
that referenced
this pull request
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.