Expand ranges when reading thread_siblings_list #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle both ranges and individual values
vzhurba01
added
the
category:improvement
bryevdv
reviewed
Oct 3, 2023
vzhurba01
force-pushed
the
system_cpu_ranges
branch
from
7411030 to
ffedd10
Compare
vzhurba01
force-pushed
the
system_cpu_ranges
branch
from
ffedd10 to
f715090
Compare
bryevdv
reviewed
Oct 4, 2023
vzhurba01
force-pushed
the
system_cpu_ranges
branch
from
91f38ef to
0c2780d
Compare
bryevdv
reviewed
Oct 4, 2023
| "1-2,0": (0, 1, 2), | ||
| "0,1-2,3,4-5,6": (0, 1, 2, 3, 4, 5, 6), | ||
| "5-6,4,1-3,0": (0, 1, 2, 3, 4, 5, 6), | ||
| } |
There was a problem hiding this comment.
BTW just FYI it's common to move values + expected values together at the same time through parameters. The danger here is that the keys in the expected dict become out of sync with the val parameter values since they are duplicated. I think this is fine in this small case, but if you are interested there are more examples, etc on the pytest site
There was a problem hiding this comment.
Created PR #851 because I really like the non-duplicating version.
manopapad
added a commit
that referenced
this pull request
Mar 5, 2025
…sk_sources (#849) * Debugging output for select_task_sources * Estimate local CPU<->GPU multi-hop copy bandwidth * Print backtraces at select_task_sources * Remove debugging output * Address review comments * Review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle both ranges and individual values