Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Performing a build with MORPHEUS_PYTHON_INPLACE_BUILD=ON and MORPHEUS_PYTHON_PERFORM_INSTALL=ON results in morpheus being installed in site-packages #1923

Closed
2 tasks done
dagardner-nv opened this issue Oct 1, 2024 · 1 comment · Fixed by nv-morpheus/utilities#81 or #1952
Assignees
Labels
bug Something isn't working

Comments

@dagardner-nv
Copy link
Contributor

Version

24.10

Which installation method(s) does this occur on?

Source

Describe the bug.

When both of these values are true this should perform an in-place editable install. Instead morpheus is installed into site-packages and in-place.

Minimum reproducible example

./scripts/compile.sh
pip show morpheus

Relevant log output

Click here to see error details

[Paste the error here, it will be hidden by default]

Full env printout

Click here to see environment details

[Paste the results of print_env.sh here, it will be hidden by default]

Other/Misc.

No response

Code of Conduct

  • I agree to follow Morpheus' Code of Conduct
  • I have searched the open bugs and have found no duplicates for this bug report
@dagardner-nv dagardner-nv added the bug Something isn't working label Oct 1, 2024
@dagardner-nv dagardner-nv self-assigned this Oct 3, 2024
@dagardner-nv dagardner-nv moved this from Todo to In Progress in Morpheus Boards Oct 3, 2024
@dagardner-nv
Copy link
Contributor Author

I spent a little time looking into this. When -DCMAKE_BUILD_TYPE=Debug is present, our cmake scripts behave as expected, without it (as it the default with compile.sh) then it presents this bug.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Morpheus Boards Oct 16, 2024
@mdemoret-nv mdemoret-nv reopened this Oct 16, 2024
@github-project-automation github-project-automation bot moved this from Done to In Progress in Morpheus Boards Oct 16, 2024
@mdemoret-nv mdemoret-nv added this to the 24.10 - Release milestone Oct 16, 2024
dagardner-nv added a commit to dagardner-nv/Morpheus that referenced this issue Oct 16, 2024
@morpheus-bot-test morpheus-bot-test bot moved this from In Progress to Review - Ready for Review in Morpheus Boards Oct 16, 2024
@rapids-bot rapids-bot bot closed this as completed in 34d2d48 Oct 16, 2024
@github-project-automation github-project-automation bot moved this from Review - Ready for Review to Done in Morpheus Boards Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment