Move cudf helper dtype_from_column_view import from type to column #2097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagardner-nv
added
bug
|
As was discussed offline rapidsai/cudf#17665 is slated for inclusion in cudf v25.02. Placing this on-hold until cudf 25.02 is released. |
|
cc: @cwharris who will likely be the person dealing with this (hopefully). |
3 tasks
Closed
Closed
rapids-bot bot
pushed a commit
that referenced
this pull request
Feb 19, 2025
* When building with DOCA in CI restrict the `MORPHEUS_CUDA_ARCHITECTURES` to just those supported by DOCA. * Install DOCA from an apt repository rather than downloading a deb file * Avoid a version conflict for the `mft` package by manually specifying the version of `mft` to ensure the package is installed from the DOCA repo and not the CUDA repo. * Incorporates changes from #2097 to `cudf_helpers.pyx` to match changes made to cudf. Closes #2182 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) - Matthew Roeschke (https://github.com/mroeschke) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) - Will Killian (https://github.com/willkill07) URL: #2183
|
These changes were rolled into the larger set of changes required for adopting cudf 25.02 (#2183). Thanks @mroeschke ! |
willkill07
pushed a commit
to dagardner-nv/Morpheus
that referenced
this pull request
Feb 21, 2025
* When building with DOCA in CI restrict the `MORPHEUS_CUDA_ARCHITECTURES` to just those supported by DOCA. * Install DOCA from an apt repository rather than downloading a deb file * Avoid a version conflict for the `mft` package by manually specifying the version of `mft` to ensure the package is installed from the DOCA repo and not the CUDA repo. * Incorporates changes from nv-morpheus#2097 to `cudf_helpers.pyx` to match changes made to cudf. Closes nv-morpheus#2182 - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) - Matthew Roeschke (https://github.com/mroeschke) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) - Will Killian (https://github.com/willkill07) URL: nv-morpheus#2183
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm removing the
cudf._lib.typesnamespace in rapidsai/cudf#17665, and the functionality used here will be moved tocudf._lib.columnBy Submitting this PR I confirm: