Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation improvements for the C++ developer guides #2160

Merged
merged 5 commits into from
Jan 30, 2025
Merged

Documentation improvements for the C++ developer guides #2160

merged 5 commits into from
Jan 30, 2025

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Jan 30, 2025 •
edited
Loading

Description

  • Add additional information on when the examples should be compiled with Morpheus or as stand-alone projects.
  • Document the need to install developer tools defined in conda/environments/dev_cuda-125_arch-$(arch).yaml when using the release container.
  • Document the need to reload the env to ensure LDFLAGS is defined.

closes #2157

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@dagardner-nv dagardner-nv added non-breaking Non-breaking change doc Improvements or additions to documentation labels Jan 30, 2025
@dagardner-nv dagardner-nv self-assigned this Jan 30, 2025
@dagardner-nv dagardner-nv requested a review from a team as a code owner January 30, 2025 20:04
@dagardner-nv dagardner-nv added this to the 25.02 - Release milestone Jan 30, 2025
willkill07
willkill07 approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@willkill07 willkill07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation enhancements LGTM

@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 9f49f34 into nv-morpheus:branch-25.02 Jan 30, 2025
14 of 15 checks passed
@dagardner-nv dagardner-nv deleted the david-dev-guide-2502 branch January 30, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willkill07 willkill07 willkill07 approved these changes

Assignees

@dagardner-nv dagardner-nv

Labels
doc Improvements or additions to documentation non-breaking Non-breaking change
Projects
None yet
Milestone
25.02 - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@dagardner-nv @willkill07