Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "update SDKs - Go 1.9 support is in the latest" #33

Merged
merged 1 commit into from
Mar 13, 2018

Conversation

brianfoshee
Copy link
Contributor

@brianfoshee brianfoshee commented Mar 13, 2018

Reverts #31

The legacy GAE SDK isn't available yet for the updated version that gcloud is on :(

Note: this travis build was marked as passing, but the docker image build step failed at trying to download the GAE SDK https://travis-ci.org/NYTimes/drone-gae/builds/352995451
#32 is a potential fix - it builds the docker image after running tests.

Copy link
Contributor

@jprobinson jprobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

@jprobinson jprobinson merged commit bbe84af into nytimes:master Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants