-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI pipeline improvements #236
Conversation
…-pipeline-improvements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Dani, really liked how CI/CD is organized now.
My only concern is the time it's taking for the Infection test stage, this is related only to environment performance?
Also, why we need the extra repository now but not before?
"repositories": [ | ||
{ | ||
"type": "vcs", | ||
"url": "https://github.com/theofidry/AliceBundle" | ||
} | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this is needed now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yes, I forgot to explain it in the PR description. It is required due to this unfortunate "incident": nelmio/alice#1089
I also noticed the slowliness, I think it is caused by the limitations of the CI server. I agree that we should investigate it together with @serge-salamanka-1pt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
LGTM
Purpose of this PR is to slightly improve the performance of our CI pipeline by parallelising the steps within it. Now the pipeline will work like this: