Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI pipeline improvements #236

Merged
merged 12 commits into from
Sep 15, 2021
Merged

CI pipeline improvements #236

merged 12 commits into from
Sep 15, 2021

Conversation

Skyld
Copy link
Contributor

@Skyld Skyld commented Sep 10, 2021

Purpose of this PR is to slightly improve the performance of our CI pipeline by parallelising the steps within it. Now the pipeline will work like this:

Screenshot 2021-09-10 at 16 13 05

@Skyld Skyld added the Type: CI Continuous integration label Sep 10, 2021
@Skyld Skyld requested review from luisfn and uncleempty September 10, 2021 14:16
@Skyld Skyld marked this pull request as ready for review September 10, 2021 14:16
Copy link
Contributor

@luisfn luisfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dani, really liked how CI/CD is organized now.

My only concern is the time it's taking for the Infection test stage, this is related only to environment performance?

Also, why we need the extra repository now but not before?

Comment on lines +54 to +59
"repositories": [
{
"type": "vcs",
"url": "https://github.com/theofidry/AliceBundle"
}
],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this is needed now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes, I forgot to explain it in the PR description. It is required due to this unfortunate "incident": nelmio/alice#1089

@Skyld Skyld requested a review from luisfn September 13, 2021 06:40
@Skyld
Copy link
Contributor Author

Skyld commented Sep 13, 2021

Thanks Dani, really liked how CI/CD is organized now.

My only concern is the time it's taking for the Infection test stage, this is related only to environment performance?

Also, why we need the extra repository now but not before?

I also noticed the slowliness, I think it is caused by the limitations of the CI server. I agree that we should investigate it together with @serge-salamanka-1pt

Copy link
Contributor

@luisfn luisfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Collaborator

@uncleempty uncleempty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
LGTM

@Skyld Skyld merged commit 784e648 into develop Sep 15, 2021
@Skyld Skyld deleted the fix/ci-pipeline-improvements branch September 15, 2021 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: CI Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants