Added public API sealed in trait_newly_sealed #1160
Merged
+77
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geetanshjuneja
commented
Feb 25, 2025
Comment on lines
+66
to
+76
| { | ||
| "name": String("WIllGainDocHiddenMethodWithoutDefault"), | ||
| "path": List([ | ||
| String("trait_method_added"), | ||
| String("WIllGainDocHiddenMethodWithoutDefault"), | ||
| ]), | ||
| "span_begin_line": Uint64(24), | ||
| "span_end_line": Uint64(27), | ||
| "span_filename": String("src/lib.rs"), | ||
| "visibility_limit": String("public"), | ||
| }, |
There was a problem hiding this comment.
Adding a hidden method also makes the trait sealed
geetanshjuneja
commented
Feb 25, 2025
Comment on lines
+42
to
+52
| { | ||
| "name": String("WillGainADocHiddenType"), | ||
| "path": List([ | ||
| String("trait_associated_type_added"), | ||
| String("WillGainADocHiddenType"), | ||
| ]), | ||
| "span_begin_line": Uint64(51), | ||
| "span_end_line": Uint64(56), | ||
| "span_filename": String("src/lib.rs"), | ||
| "visibility_limit": String("public"), | ||
| }, |
There was a problem hiding this comment.
same reason as above
geetanshjuneja
commented
Feb 25, 2025
Comment on lines
+18
to
+28
| { | ||
| "name": String("WillGainADocHiddenConst"), | ||
| "path": List([ | ||
| String("trait_associated_const_added"), | ||
| String("WillGainADocHiddenConst"), | ||
| ]), | ||
| "span_begin_line": Uint64(46), | ||
| "span_end_line": Uint64(51), | ||
| "span_filename": String("src/lib.rs"), | ||
| "visibility_limit": String("public"), | ||
| }, |
There was a problem hiding this comment.
The trait WillGainADocHiddenConst becomes public api sealed due addition of a hidden const. Hence it is newly sealed now and error is raised
obi1kenobi
approved these changes
Feb 25, 2025
There was a problem hiding this comment.
In the spirit of mirroring the existing code, I'm adding some explanatory comments to the new test cases to explain what's going on. They make it much easier for me to look back and figure out what we're testing down the line, e.g. if someone reports a bug in our lints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1115