Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change trait "object safe" terminology to "dyn compatible" #535

Closed
1 of 2 tasks
obi1kenobi opened this issue Oct 18, 2024 · 0 comments
Closed
1 of 2 tasks

Change trait "object safe" terminology to "dyn compatible" #535

obi1kenobi opened this issue Oct 18, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@obi1kenobi
Copy link
Owner

obi1kenobi commented Oct 18, 2024 •
edited
Loading

Rust more broadly is adopting this terminology change: rust-lang/rust#130852

We should update our Trait data model to use the new terminology in its properties.

To avoid hard breakage, this should be a two-step process:

  • add a new dyn_compatible: Boolean! property that has identical data to the existing object_safe: Boolean! property
  • eventually, after a suitable migration period, remove the object_safe property
@obi1kenobi obi1kenobi added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Oct 18, 2024
@obi1kenobi obi1kenobi mentioned this issue Oct 18, 2024
Closed
@Frank-III Frank-III mentioned this issue Jan 27, 2025
Merged
obi1kenobi added a commit that referenced this issue Jan 27, 2025
@Frank-III @obi1kenobi
add dyn_compatible field to Trait data model (#718)
477a3ae 
close part of #535

---------

Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com>
obi1kenobi added a commit that referenced this issue Jan 27, 2025
@Frank-III @obi1kenobi
add dyn_compatible field to Trait data model (#718)
26c54e8 
close part of #535

---------

Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com>
@obi1kenobi obi1kenobi mentioned this issue Jan 27, 2025
Merged
obi1kenobi added a commit that referenced this issue Jan 27, 2025
@Frank-III @obi1kenobi
add dyn_compatible field to Trait data model (#718)
0e69f22 
close part of #535

---------

Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com>
@obi1kenobi obi1kenobi mentioned this issue Jan 27, 2025
Merged
obi1kenobi added a commit that referenced this issue Jan 27, 2025
@obi1kenobi @Frank-III
add dyn_compatible field to Trait data model (#718) (#719)
bdad798 
close part of #535

---------

Co-authored-by: Predrag Gruevski
<2348618+obi1kenobi@users.noreply.github.com>

Co-authored-by: frankwang <73262844+Frank-III@users.noreply.github.com>
obi1kenobi added a commit that referenced this issue Jan 27, 2025
@obi1kenobi @Frank-III
add dyn_compatible field to Trait data model (#718) (#720)
9f64828 
close part of #535

---------

Co-authored-by: Predrag Gruevski
<2348618+obi1kenobi@users.noreply.github.com>

Co-authored-by: frankwang <73262844+Frank-III@users.noreply.github.com>
obi1kenobi added a commit that referenced this issue Jan 27, 2025
@Frank-III @obi1kenobi
add dyn_compatible field to Trait data model (#718)
25bd8c1 
close part of #535

---------

Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com>
@obi1kenobi obi1kenobi mentioned this issue Jan 27, 2025
Merged
obi1kenobi added a commit that referenced this issue Jan 27, 2025
@Frank-III @obi1kenobi
add dyn_compatible field to Trait data model (#718)
24862e1 
close part of #535

---------

Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com>
@obi1kenobi obi1kenobi mentioned this issue Jan 27, 2025
Merged
obi1kenobi added a commit that referenced this issue Jan 27, 2025
@Frank-III @obi1kenobi
add dyn_compatible field to Trait data model (#718)
4c11bb3 
close part of #535

---------

Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com>
@obi1kenobi obi1kenobi mentioned this issue Jan 27, 2025
Merged
obi1kenobi added a commit that referenced this issue Jan 27, 2025
@obi1kenobi @Frank-III
add dyn_compatible field to Trait data model (#718) (#721)
5eeca87 
close part of #535

---------

Co-authored-by: Predrag Gruevski
<2348618+obi1kenobi@users.noreply.github.com>

Co-authored-by: frankwang <73262844+Frank-III@users.noreply.github.com>
obi1kenobi added a commit that referenced this issue Jan 27, 2025
@obi1kenobi @Frank-III
add dyn_compatible field to Trait data model (#718) (#722)
61f3312 
close part of #535

---------

Co-authored-by: Predrag Gruevski
<2348618+obi1kenobi@users.noreply.github.com>

Co-authored-by: frankwang <73262844+Frank-III@users.noreply.github.com>
obi1kenobi added a commit that referenced this issue Jan 27, 2025
@obi1kenobi @Frank-III
add dyn_compatible field to Trait data model (#718) (#723)
dd6ac06 
close part of #535

---------

Co-authored-by: Predrag Gruevski
<2348618+obi1kenobi@users.noreply.github.com>

Co-authored-by: frankwang <73262844+Frank-III@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@obi1kenobi