Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

facet positioning breaks for marks that render a SVGSVGElement #2218

Closed
Fil opened this issue Nov 1, 2024 · 0 comments · Fixed by #2219
Closed

facet positioning breaks for marks that render a SVGSVGElement #2218

Fil opened this issue Nov 1, 2024 · 0 comments · Fixed by #2219
Assignees
Labels
bug Something isn’t working

Comments

@Fil
Copy link
Contributor

Fil commented Nov 1, 2024

Elements rendered by a mark are positioned with transform: translate(x,y), which is not supported by SVGSVGElement. So all facets end up at the same location.

It's a bug because our documentation states that the render transform must return an "SVG Element"

Marks may also be a function which returns an SVG element, if you wish to insert arbitrary content. (Here we use [Hypertext Literal](https://github.com/observablehq/htl) to generate an SVG gradient.)

(and SVGSVGElement is a child of SVGElement).

@Fil Fil added the bug Something isn’t working label Nov 1, 2024
@Fil Fil self-assigned this Nov 1, 2024
Fil added a commit that referenced this issue Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn’t working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant