Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add a selector to hide tokens from partition-view pages #528

Closed
erikmd opened this issue Mar 21, 2023 · 1 comment · Fixed by #540, #511 or ocaml/opam-repository#24305
Closed

Feature: Add a selector to hide tokens from partition-view pages #528

erikmd opened this issue Mar 21, 2023 · 1 comment · Fixed by #540, #511 or ocaml/opam-repository#24305
Assignees
@Plictox
Labels
kind: feature New user-facing feature.
Milestone
learn-ocaml 0.15.0

Comments

@erikmd
Copy link
Member

erikmd commented Mar 21, 2023 •
edited
Loading

Related user(s):

@erikmd

Related issue(s) or PR(s):

No response

Related project scope(s):

partition-view

The problem:

The partition-view can be very useful to provide students with feedback on the variability of the available answers.

However, each cluster and answer is annotated with a token, meaning it is impossible for teachers to share their screen.

Wanted solution:

  • Add a selector (checkboxes or dropdown) that allows teacher to show only: Nickname, or Token, or the list of tags decided in the Teacher dashboard, or Nothing-or-line-numbers (1. 2. 3. …)
  • Show the Nicknames by default (not the Tokens).

Considered alternatives:

  • @yurug: Generate a dissimilarity report (that can be shared with students), maybe run ocamlformat?

Additional context:

No response
@erikmd erikmd added the kind: feature New user-facing feature. label Mar 21, 2023
@erikmd erikmd changed the title Feature: add a selector (checkbox) to hide tokens from partition-view pages Feature: add a selector to hide tokens from partition-view pages Mar 21, 2023
@erikmd erikmd changed the title Feature: add a selector to hide tokens from partition-view pages Feature: Add a selector to hide tokens from partition-view pages Mar 21, 2023
@erikmd erikmd mentioned this issue Mar 22, 2023
Open
@erikmd
Copy link
Member Author

erikmd commented Apr 7, 2023

Hint: the implementation of this feature amounts to modifying these files:

@Plictox Plictox mentioned this issue Apr 20, 2023
Merged
6 tasks
erikmd added a commit that referenced this issue May 1, 2023
@Plictox @erikmd
feat(partition-view): Add a selector to show (tokens, nicks, or anon …
58b3644 
…IDs) (#540)

This makes it possible to video-project the partition-view page,
without risking to leak all the tokens!

Also, fix the order of tabs in responsive mode:

1. "List"
2. "Details"
3. "Answer"

Close #528

Co-authored-by: Louis Tariot <louis.tariot@irit.fr>
Co-authored-by: Erik Martin-Dorel <erik@martin-dorel.org>
@erikmd erikmd added this to the learn-ocaml 1.0.0 milestone May 1, 2023
@github-actions github-actions bot mentioned this issue May 1, 2023
Merged
@erikmd erikmd mentioned this issue Aug 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Plictox Plictox

Labels
kind: feature New user-facing feature.
Projects
None yet
Milestone
learn-ocaml 0.15.0
2 participants
@erikmd @Plictox