Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow tagged packages to be uninstalled #202

Merged
merged 3 commits into from
Nov 19, 2020

Conversation

chadian
Copy link
Contributor

@chadian chadian commented Nov 18, 2020

Currently trying to uninstall a package using a tag name works for install but not uninstalling. The tag can be ignored and the uninstall should work with just the package name. This package has a oclif scope of heroku-plugins in the package.json which is why ./bin/run plugins:install apps works in the tests.

test

# friendly
./bin/run plugins:install apps
./bin/run plugins
./bin/run plugins:uninstall apps

# scoped
./bin/run plugins:install @heroku-cli/plugin-apps
./bin/run plugins
./bin/run plugins:uninstall @heroku-cli/plugin-apps

# tagged
./bin/run plugins:install @heroku-cli/plugin-apps@latest
./bin/run plugins
./bin/run plugins:uninstall @heroku-cli/plugin-apps@latest

# unscoped
./bin/run plugins:install salesforce-alm
./bin/run plugins
./bin/run plugins:uninstall salesforce-alm

result

Installing plugin apps... installed v7.47.0
apps 7.47.0
Uninstalling apps... done
Installing plugin apps... installed v7.47.0
apps 7.47.0
Uninstalling apps... done
Installing plugin apps... installed v7.47.0
apps 7.47.0
Uninstalling apps... done
warning salesforce-alm > request-promise-native@1.0.9: request-promise-native has been deprecated because it extends the now deprecated request package, see https://github.com/request/request/issues/3142
warning salesforce-alm > request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
warning salesforce-alm > jsforce > request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
warning salesforce-alm > @salesforce/core > jsforce > request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
warning salesforce-alm > request > har-validator@5.1.5: this library is no longer supported
Installing plugin salesforce-alm... installed v50.6.0
salesforce-alm 50.6.0
Uninstalling salesforce-alm... done

@chadian chadian force-pushed the uninstall-tagged-packages branch from 0ea6dcb to 047ebf5 Compare November 19, 2020 18:19
@chadian chadian force-pushed the uninstall-tagged-packages branch from 047ebf5 to d61072d Compare November 19, 2020 19:02
@chadian chadian force-pushed the uninstall-tagged-packages branch from d61072d to bf8a2fa Compare November 19, 2020 19:39
@chadian chadian merged commit 716569c into master Nov 19, 2020
@chadian chadian deleted the uninstall-tagged-packages branch November 19, 2020 21:34
oclif-bot added a commit that referenced this pull request Nov 19, 2020
## [1.9.4](v1.9.3...v1.9.4) (2020-11-19)

### Bug Fixes

* allow tagged packages to be uninstalled ([#202](#202)) ([716569c](716569c))
@oclif-bot
Copy link
Contributor

🎉 This PR is included in version 1.9.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants