Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Thai language support #743

Closed
wants to merge 4 commits into from
Closed

Add Thai language support #743

wants to merge 4 commits into from

Conversation

nProtect
Copy link
Contributor

Add Thai language support via GetGlyphRangesThai()

@ocornut
Copy link
Owner

ocornut commented Jul 19, 2016

Thanks! To apply the PR as-is with your login/commit name please try to follow the coding convention of ImGui (spaces after //, 4-spaces instead of tabs).

@nProtect
Copy link
Contributor Author

OK I have changed tab to spaces. Thanks for recommend me.

@ocornut
Copy link
Owner

ocornut commented Jul 20, 2016

I have merged it now and applied fixes. Please pay more attentions when submitting PR in order to make it easier for the project manager to merge changes.

  • rebase-squashed your 4 commits into ones
  • it was missing spaces after //
  • it was still using lots of tabs in imgui_draw.cpp
  • there was a typo

4141144
8efd05a

Thanks!

@ocornut ocornut closed this Jul 20, 2016
@ocornut
Copy link
Owner

ocornut commented Mar 5, 2025

#8465 is making the use of glyph range functions unnecessary, so GetGlyphRangesThai() will eventually be removed once the work on dynamic_fonts is over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants