-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TestSuite: added "docking_dockspace_copy_no_remap" #20
base: main
Are you sure you want to change the base?
TestSuite: added "docking_dockspace_copy_no_remap" #20
Conversation
Relates to imgui-6035
137958b
to
193469f
Compare
This test was originally failing only for Linux docking on CI. I did not have time to fully investigate why it was failing, but based on a hunch from a similar issue with #19 I guessed it was due to I can investigate further if you find that fix unsatisfactory. It'd definitely be nice to know why Linux docking CI in particular seems to find these issues, but it might be a deep rabbit hole too. (I tested locally with WSLg and it passed there, which suggests it might be CI-specific rather than Linux docking-specific.) I know for #19 I ended up figuring out that |
Thanks for the PR. That’s worth investigating separately, perhaps with its own test. And I guess maybe that function should be GetWindowTitlebarPointForMoving. |
While we are here I suggest adding some basic sanity tests to check for the behavior of |
Regression test for ocornut/imgui#6035
Verified by intentionally regressing ocornut/imgui@6939676