-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runtime: use monomorphic representation for MlBytes #1229
base: master
Are you sure you want to change the base?
Conversation
70788ba
to
22b4d7e
Compare
2621eae
to
13b9ae1
Compare
88ff06d
to
dd4f273
Compare
If we make |
a490036
to
d2e6f04
Compare
d2e6f04
to
27ec06c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
runtime/js/mlBytes.js:223
- The bitwise OR operation with 0 is unnecessary and can be removed.
return s.a[i] | 0;
Using
deoptigate
to check performances/optimizationsprobably blocked by #1045