Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nan to be compatible with newer Node.js versions. #1

Closed
octalmage opened this issue Sep 25, 2014 · 12 comments
Closed

Use nan to be compatible with newer Node.js versions. #1

octalmage opened this issue Sep 25, 2014 · 12 comments
Assignees
Milestone

Comments

@octalmage
Copy link
Owner

I need to use nan to make RobotJS compatible with newer versions of node.js.

@octalmage octalmage self-assigned this Sep 25, 2014
@anand-io
Copy link

@octalmage, robotjs is awesome. I want to use this with latest node.js. When will this be ready?
Thanks.

@octalmage
Copy link
Owner Author

I'm glad you like RobotJS! Unfortunately I'm not sure when it will be ready. It was harder than I originally thought and I need time to work on it.

It is something I'm very interested in though. RobotJS is almost useless to me without this.

@octalmage octalmage changed the title Use nan. Use nan to be compatible with newer Node.js versions. Jan 27, 2015
@anand-io
Copy link

I am also trying to modify RobotJS using nan and it is harder than I imagined. Thanks for your response. 👍

@octalmage
Copy link
Owner Author

No problem! I started the work here:

https://github.com/octalmage/robotjs/tree/nan

I'll take a look now, see if I can make some progress.

@octalmage
Copy link
Owner Author

Actually got it working and converted a function:

87fe58e

I'll finish the rest later, shouldn't be much longer.

@anand-io
Copy link

Hey thanks, that function got build and working perfectly.

@octalmage
Copy link
Owner Author

Great work in 09b115e! Do you want to finish off the conversion?

@anand-io
Copy link

At first I just compiled that function then I made some changes to other functions by forking the project 09b115e. And all of it is compiled in the node version 0.11.13 and woking.

@octalmage
Copy link
Owner Author

I saw that, thanks a ton man!

When it's done submit a pull request! 😉 🎉

@octalmage octalmage modified the milestone: First Stable Release. Jan 29, 2015
@octalmage
Copy link
Owner Author

@anand-seeenivasagam since your repository now contains code that is not cross platform it can't be merged. I finished the conversion myself.

@anand-io
Copy link

Thats allright! I will try to make the changes cross platform because we need it in future. Thanks! :)

@octalmage
Copy link
Owner Author

Awesome! Thanks again for your help!

octalmage pushed a commit that referenced this issue Aug 21, 2015
@Venryx Venryx mentioned this issue Jul 28, 2016
someonewasherebefore pushed a commit to someonewasherebefore/robotjs that referenced this issue Oct 4, 2019
FossPrime pushed a commit to FossPrime/robotjs that referenced this issue Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants