Bitmap save and new screen capture for Mac. #191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I started working on bitmap saving and realized there was an issue with the screen capture code on Mac. Due to the high DPI, images should be double the size of the screen. Instead the saved images were the same size, with double the pixels written to the file.
This change has the potential to break backwards compatibility for users using colorAt. To correct this, they can get the image size, divide it by the screen size, then multiply their colorAt coordinates by the result.
This isn't perfect yet, there's an issue when writing images to disk that are smaller than 16px, but it's a start.
Todo
Resolves #188