Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This is an attempt to fix #580 and make robotjs context-aware and usable in the latest versions of Electron:
Reproduceble just by requiring
robotjs
anywhere in an Electron>= 9.0.0
app.Electron and native apps
app.allowRendererProcessReuse
totrue
by default, making robotjs throw a deprecated error when instantiated (workaround is to put this value tofalse
)This means robotjs will simply stop working on Electron in the future.
Source: electron/electron#18397
Changes
Context-awareness was added to
node
since version 10, to keep robotjs backward-compatible, I've put the new initialization in a version condition.Tests
I tested on an Electron
9.4.0
app: it got rid of the error and I was able to use robotjs.Disclaimer: I'm not a
C
orC++
developer at all, I would need review so I'm not introducing something unwanted. Based myself on https://nodejs.org/api/addons.html#addons_context_aware_addons.