Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add renovate configuration to Repository if repository is in @octokit #98

Closed
gr2m opened this issue Mar 9, 2021 · 11 comments · Fixed by #193
Closed

add renovate configuration to Repository if repository is in @octokit #98

gr2m opened this issue Mar 9, 2021 · 11 comments · Fixed by #193
Assignees
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Comments

@gr2m
Copy link
Contributor

gr2m commented Mar 9, 2021

No description provided.

@gr2m gr2m changed the title add renovate configuration to package.json add renovate configuration to package.json if repository is in @octokit Mar 9, 2021
@gr2m gr2m added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Mar 9, 2021
@oscard0m

This comment was marked as resolved.

@gr2m

This comment was marked as resolved.

@oscard0m oscard0m self-assigned this May 11, 2021
@oscard0m

This comment was marked as resolved.

@wolfy1339

This comment was marked as resolved.

@oscard0m

This comment was marked as resolved.

@gr2m

This comment was marked as resolved.

@oscard0m
Copy link
Member

oscard0m commented Aug 31, 2022

I added some missing logic to @octoherd/script-setup-renovate. I think we are ready to run this across the repos of the org you would like to have Renovate.

I noticed it creates/updates .json removing the new lines and spaces completely, is this a blocker to our use-case? (see octoherd/script-setup-renovate#29)

➡️ fixed here

The script requires a token with privileges to push directly on the defaultBranch branch. @gr2m


Pending to do the removal of pkg.renovate entry from package.json. I'm assuming .github/renovate.json will take precedence according to Renovate Documentation.

➡️ Octoherd script ready to remove the entries from package.json 🍾 octoherd-script-remove-renovate-package.json/

@gr2m
Copy link
Contributor Author

gr2m commented Sep 6, 2022

So there are two things we need to do, if I get it correctly

  1. move the renovate configuration in current @octokit repositories from the package.json files to .github/renovate.json (as we just did in @probot)
  2. Create a .github/renovate.json file when running npm init octokit-project and creating a @octokit repositor (this is the original scope of this issue)

Did I get this right?

I can run the scripts to conclude step 1 if everything is ready @oscard0m

@oscard0m
Copy link
Member

oscard0m commented Sep 7, 2022

So there are two things we need to do, if I get it correctly

  1. move the renovate configuration in current @octokit repositories from the package.json files to .github/renovate.json (as we just did in @probot)

  2. Create a .github/renovate.json file when running npm init octokit-project and creating a @octokit repositor (this is the original scope of this issue)

Did I get this right?

I can run the scripts to conclude step 1 if everything is ready @oscard0m

The steps are correct and the scripts are ready 🚀 .

@oscard0m oscard0m changed the title add renovate configuration to package.json if repository is in @octokit add renovate configuration to Repository if repository is in @octokit Sep 7, 2022
@gr2m
Copy link
Contributor Author

gr2m commented Sep 8, 2022

I updated all @octokit repositories. Only thing left now is

Create a .github/renovate.json file when running npm init octokit-project and creating a https://github.com/octokit repositor (this is the original scope of this issue)

@github-actions
Copy link

github-actions bot commented Sep 9, 2022

🎉 This issue has been resolved in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants