Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Renovate - autoclosed #4

Closed
wants to merge 1 commit into from
Closed

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 4, 2021

Mend Renovate

Welcome to Renovate! This is an onboarding PR to help you understand and configure settings before regular Pull Requests begin.

🚦 To activate Renovate, merge this Pull Request. To disable Renovate, simply close this Pull Request unmerged.


Configuration

🔡 Renovate has detected a custom config for this PR. Feel free to ask for help if you have any doubts and would like it reviewed.

Important: Now that this branch is edited, Renovate can't rebase it from the base branch any more. If you make changes to the base branch that could impact this onboarding PR, please merge them manually.

What to Expect

It looks like your repository dependencies are already up-to-date and no Pull Requests will be necessary right away.


❓ Got questions? Check out Renovate's Docs, particularly the Getting Started section.
If you need any further assistance then you can also request help here.


This PR has been generated by Mend Renovate. View repository job log here.

Verified

This commit was created on github.com and signed with GitHub’s verified signature. The key has expired.
@renovate renovate bot force-pushed the renovate/configure branch from 603e3a1 to 1269851 Compare June 26, 2022 09:21
Copy link
Member

@oscard0m oscard0m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we want to use package.json as in the other repos?

"renovate": {
    "extends": [
      "github>octokit/.github"
    ]
  }

@wolfy1339
Copy link
Member

Renovate is deprecating putting config's in package.json

https://docs.renovatebot.com/configuration-options/ — See the warning

@wolfy1339
Copy link
Member

This should be part of #1 anyways

@oscard0m
Copy link
Member

Renovate is deprecating putting config's in package.json

https://docs.renovatebot.com/configuration-options/ — See the warning

Interesting, I guess we need to migrate all the repositories from package.json to renovate.json right?

@wolfy1339
Copy link
Member

Interesting, I guess we need to migrate all the repositories from package.json to renovate.json right?

Exactly

@gr2m
Copy link
Contributor

gr2m commented Jun 26, 2022

I guess we need to migrate all the repositories from package.json to renovate.json right?

ugh :( I really dislike adding more meta files into repositories.

Can we agree on putting them in .github/renovate.json? I think we could write an @octoherd script to do the update, have that script reviewed, and then run it directly against the repositories' default branches instead of creating pull requests, to avoid the noise. Let me know what you think

@oscard0m
Copy link
Member

I guess we need to migrate all the repositories from package.json to renovate.json right?

ugh :( I really dislike adding more meta files into repositories.

Can we agree on putting them in .github/renovate.json? I think we could write an @octoherd script to do the update, have that script reviewed, and then run it directly against the repositories' default branches instead of creating pull requests, to avoid the noise. Let me know what you think

I’m in for the plan. I will work on it. There’s an existing octoherd script for renovate we can extend. I will draft something this week and tag you.

@oscard0m
Copy link
Member

@wolfy1339 I see we have done the migration for all (?) the repos of Octokit. Should we create a PR for this as well?

@wolfy1339
Copy link
Member

We haven't done the migration on all the repos. Just a couple have been done.

@oscard0m
Copy link
Member

We haven't done the migration on all the repos. Just a couple have been done.

ok, so an Octoherd script is still necessary, right?

@wolfy1339
Copy link
Member

ok, so an Octoherd script is still necessary, right?

That is correct. It should be very simple to implement

@oscard0m
Copy link
Member

ok, so an Octoherd script is still necessary, right?

That is correct. It should be very simple to implement

Tomorrow I plan to work on this, and after that, I can take a look at the octoherd script.

@oscard0m
Copy link
Member

oscard0m commented Aug 31, 2022

Tomorrow I plan to work on this, and after that, I can take a look at the octoherd script.

Updated status here: octokit/create-octokit-project.js#98 (comment)

@renovate renovate bot changed the title Configure Renovate Configure Renovate - autoclosed Sep 8, 2022
@renovate renovate bot closed this Sep 8, 2022
@renovate renovate bot deleted the renovate/configure branch September 8, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants