-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update dependency @octokit/request-error to v6.1.7 [security] #2816
Merged
wolfy1339
merged 2 commits into
main
from
renovate/npm-octokit-request-error-vulnerability
Feb 15, 2025
Merged
fix(deps): update dependency @octokit/request-error to v6.1.7 [security] #2816
wolfy1339
merged 2 commits into
main
from
renovate/npm-octokit-request-error-vulnerability
Feb 15, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c1ed743
to
d56df77
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
wolfy1339
approved these changes
Feb 15, 2025
🎉 This PR is included in version 4.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Feb 15, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.0 | 4.1.2 | ## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2) ##### Bug Fixes - **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745)) ## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1) ##### Bug Fixes - **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Feb 16, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.0 | 4.1.2 | ## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2) ##### Bug Fixes - **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745)) ## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1) ##### Bug Fixes - **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Feb 19, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.0 | 4.1.2 | ## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2) ##### Bug Fixes - **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745)) ## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1) ##### Bug Fixes - **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Feb 21, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.0 | 4.1.2 | ## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2) ##### Bug Fixes - **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745)) ## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1) ##### Bug Fixes - **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Feb 22, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.0 | 4.1.2 | ## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2) ##### Bug Fixes - **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745)) ## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1) ##### Bug Fixes - **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Feb 23, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.0 | 4.1.2 | ## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2) ##### Bug Fixes - **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745)) ## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1) ##### Bug Fixes - **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Feb 26, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.0 | 4.1.2 | ## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2) ##### Bug Fixes - **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745)) ## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1) ##### Bug Fixes - **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Mar 1, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.0 | 4.1.2 | ## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2) ##### Bug Fixes - **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745)) ## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1) ##### Bug Fixes - **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Mar 2, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.0 | 4.1.2 | ## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2) ##### Bug Fixes - **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745)) ## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1) ##### Bug Fixes - **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Mar 5, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.0 | 4.1.2 | ## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2) ##### Bug Fixes - **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745)) ## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1) ##### Bug Fixes - **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
6.1.6
->6.1.7
GitHub Vulnerability Alerts
CVE-2025-25289
Summary
A Regular Expression Denial of Service (ReDoS) vulnerability exists in the processing of HTTP request headers. By sending an authorization header containing an excessively long sequence of spaces followed by a newline and "@", an attacker can exploit inefficient regular expression processing, leading to excessive resource consumption. This can significantly degrade server performance or cause a denial-of-service (DoS) condition, impacting availability.
Details
The issue occurs at line 52 of iterator.ts in the @octokit/request-error repository.
The vulnerability is caused by the use of an inefficient regular expression in the handling of the
authorization
header within the request processing logic:The regular expression
/ .*$/
matches a space followed by any number of characters until the end of the line. This pattern is vulnerable to Regular Expression Denial of Service (ReDoS) when processing specially crafted input. Specifically, an attacker can send anauthorization
header containing a long sequence of spaces followed by a newline and "@", such as:Due to the way JavaScript's regular expression engine backtracks while attempting to match the space followed by arbitrary characters, this input can cause excessive CPU usage, significantly slowing down or even freezing the server. This leads to a denial-of-service condition, impacting availability.
PoC
The gist of PoC.js
result:
Impact
Vulnerability Type & Impact:
This is a
Regular Expression Denial of Service (ReDoS) vulnerability
, which occurs due to an inefficient regular expression (/ .*$/
) used to sanitize theauthorization
header. An attacker can craft a malicious input that triggers excessive backtracking in the regex engine, leading to high CPU consumption and potential denial-of-service (DoS).Who is Impacted?
authorization
headers are at risk, especially those processing a large volume of authentication requests.Release Notes
octokit/request-error.js (@octokit/request-error)
v6.1.7
Compare Source
Bug Fixes
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.