-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create test is_filetype_supported #30
Conversation
Great work 🎉 , @Yoda-Canada! Just a small issue with the name of each test. I'd rather have something as verbose as |
I have changed all names, but there are three commits. I am confused how to merge them to one. Because I feched new commit from your origin rpo, and when I |
Sorry if I didn't make it clear enough, @Yoda-Canada. What I was trying to say is that you should name the test cases according to what it wants to test. def test_supported_windows_file_path6():
file_path = "/Users/anonymous/Documents/test"
assert is_filetype_supported(file_path) == False, "empty extension error"
|
Don't worry about rebasing for now. I can help you with that from my end. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright! Thanks a lot for your contribution 👏
please help me to merge all commits. I always have mistakes to do it. thx. |
Fix #28
test file for issue #28