Rename from KHR_audio to KHR_audio_emitter and add example file #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See omigroup/gltf-extensions#205 and omigroup/gltf-extensions#207
See KhronosGroup#2137 (review)
This PR renames the extension to
KHR_audio_emitter
to be more similar to the names of the extensions this originally came from (OMI_audio_emitter
andMSFT_audio_emitter
).Reasoning:
Gives us the opportunity to have more extensions under the
KHR_audio_
scope. For example, I could see possible KHR_audio_listener, KHR_audio_material, KHR_audio_reverb, etc extensions. And of course, we would want extensions for specific audio types, like KHR_audio_opus, KHR_audio_vorbis, etc. ThenKHR_audio
would refer to a whole family of extensions, instead of a single extension.Is more descriptive of what the extension does.
KHR_audio
doesn't say what it actually does to the audio. Does it do everything with audio? No. Does it listen to audio? No. Does it define how audio reverbs in an area or off of objects? No. Does it define footstep sounds? No.KHR_audio_emitter
describes that it's an extension for emitting audio.I don't see a strong reason to use the name
KHR_audio
.