663 + 664/ Fractional price display + handling no price data #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lealobanov
changed the title
lealobanov
changed the title
lealobanov
commented
Mar 6, 2025
jaymengxy
reviewed
Mar 7, 2025
| // For prices at least $0.0001, use normal formatting with min 2 and max 4 decimals. | ||
| if (price >= 0.0001) { | ||
| // Use BigDecimal for precise rounding. Scale to 4, rounding up. | ||
| val bd = BigDecimal(price).setScale(4, RoundingMode.UP) |
There was a problem hiding this comment.
In scenarios involving monetary amounts, it is generally recommended to use RoundingMode.DOWN to prevent users from seeing an inflated amount. This helps avoid situations where users see an available balance that they actually cannot use.
There was a problem hiding this comment.
@JeffreyDoyle thoughts on the above? The logic in the issue suggests to round up, but agree this might be misleading to users.
There was a problem hiding this comment.
@jaymengxy discussed this during standup, agreed to round all the values down
jaymengxy
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #663 and #664
Summary of Changes
Update token formatting logic to format values > 0 and < 0.01 according to the logic outlined in #663.
Also update to hide 0.00 and "-" prices/values, replacing with an empty string.
Example:
Need Regression Testing
Risk Assessment
Additional Notes
Screenshots (if applicable)