Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header's to_dict() returns None for private tags #59

Closed
ZviBaratz opened this issue Jul 23, 2021 · 0 comments
Closed

Header's to_dict() returns None for private tags #59

ZviBaratz opened this issue Jul 23, 2021 · 0 comments
Assignees
@ZviBaratz
Labels
bug Something isn't working

Comments

@ZviBaratz
Copy link
Collaborator

Extraction by keyword doesn't always work for private tags, and therefore it would be better to simply extract all elements by tag.
@ZviBaratz ZviBaratz added the bug Something isn't working label Jul 23, 2021
@ZviBaratz ZviBaratz self-assigned this Jul 23, 2021
ZviBaratz added a commit that referenced this issue Jul 23, 2021
@ZviBaratz
Merge pull request #60 from ZviBaratz/fix
55ba75b 
Fixed private tag exclusion from the to_dict() method, resolves #59.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZviBaratz ZviBaratz

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ZviBaratz