Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reppoint bug fix when negative image training #396

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

MinkiSong
Copy link
Contributor

bug fix when negative image training using reppoint head

Motivation

image
error when number of gt bbox is zero

Modification

  1. Added exception handling to get_pos_loss function of RotatedRepPointsHead class.
  2. Added exception handling to convex_overlaps function of MaxConvexIoUAssigner class.

@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #396 (aedb8ae) into main (01439d1) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #396      +/-   ##
==========================================
- Coverage   30.85%   30.83%   -0.02%     
==========================================
  Files         119      119              
  Lines        7936     7941       +5     
  Branches     1221     1223       +2     
==========================================
  Hits         2449     2449              
- Misses       5386     5391       +5     
  Partials      101      101              
Flag Coverage Δ
unittests 30.81% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ate/core/bbox/assigners/max_convex_iou_assigner.py 13.75% <0.00%> (-0.36%) ⬇️
...otate/models/dense_heads/rotated_reppoints_head.py 6.77% <0.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01439d1...aedb8ae. Read the comment docs.

Copy link
Collaborator

@zytx121 zytx121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zytx121
Copy link
Collaborator

zytx121 commented Jul 28, 2022

Thanks for your PR. It's helpful for MMRotate.

@zytx121 zytx121 changed the base branch from main to dev July 28, 2022 23:38
@ZwwWayne ZwwWayne merged commit 7c3db70 into open-mmlab:dev Aug 1, 2022
@zytx121 zytx121 mentioned this pull request Oct 26, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants