Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add RotatedBoxes and QuadriBoxes data structure in mmrotate. #450

Merged
merged 17 commits into from
Aug 19, 2022

Conversation

jbwang1997
Copy link
Collaborator

@jbwang1997 jbwang1997 commented Aug 6, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add RotatedBoxes and QuadriBoxes data structure in mmrotate.

  • Initialize RotatedBoxes and QuadriBoxes
  • Add converters for HorizontalBoxes, RotatedBoxes, and QuadriBoxes.
  • Add docstring for RotatedBoxes and QuadriBoxes
  • Add UT for all new features.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. The documentation has been modified accordingly, like docstring or example tutorials.

@zytx121
Copy link
Collaborator

zytx121 commented Aug 8, 2022

In pipeline, bbox type is list[float]. If we want to flip the rbboxes in pipeline, do we just need to convert the list to Tensor first? Or should we need to create another convert function for list or numpy?

@jbwang1997
Copy link
Collaborator Author

jbwang1997 commented Aug 8, 2022

In LoadAnnotations, All bboxes will first be replaced by BoxList. What's more convert_bbox_mode can also accept tensor and numpy data types.

@jbwang1997 jbwang1997 changed the title [WIP] Add RotatedBoxes and QuadriBoxes data structure in mmrotate. [Feature] Add RotatedBoxes and QuadriBoxes data structure in mmrotate. Aug 11, 2022
hhaAndroid
hhaAndroid previously approved these changes Aug 12, 2022
RangiLyu
RangiLyu previously approved these changes Aug 17, 2022
@RangiLyu RangiLyu merged commit 9e6cc9b into open-mmlab:dev-1.x Aug 19, 2022
@zytx121 zytx121 mentioned this pull request Nov 5, 2022
triple-Mu pushed a commit to triple-Mu/mmrotate that referenced this pull request Jan 31, 2023
open-mmlab#450)

* Initialize RotatedBoxes and QuadriBoxes

* Move all box modes into Structures, Add docstring

* Update docstring

* Upload UT

* Fix comments

* Update inplace operations

* Update

* Update

* Update

* Update

* Updata rotate and project UT

* Update

* Update

* Update

* Update

* update

* Update from_instance_masks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants