-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add RotatedBoxes and QuadriBoxes data structure in mmrotate. #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In pipeline, bbox type is list[float]. If we want to flip the rbboxes in pipeline, do we just need to convert the list to Tensor first? Or should we need to create another convert function for list or numpy? |
In LoadAnnotations, All bboxes will first be replaced by BoxList. What's more |
hhaAndroid
reviewed
Aug 8, 2022
hhaAndroid
reviewed
Aug 8, 2022
hhaAndroid
reviewed
Aug 10, 2022
chhluo
reviewed
Aug 10, 2022
hhaAndroid
previously approved these changes
Aug 12, 2022
zytx121
reviewed
Aug 16, 2022
tests/test_core/test_bbox/test_structures/test_rotated_boxes.py
Outdated
Show resolved
Hide resolved
zytx121
reviewed
Aug 16, 2022
RangiLyu
reviewed
Aug 17, 2022
RangiLyu
reviewed
Aug 17, 2022
RangiLyu
reviewed
Aug 17, 2022
RangiLyu
previously approved these changes
Aug 17, 2022
RangiLyu
reviewed
Aug 19, 2022
3 tasks
RangiLyu
approved these changes
Aug 19, 2022
Merged
triple-Mu
pushed a commit
to triple-Mu/mmrotate
that referenced
this pull request
Jan 31, 2023
open-mmlab#450) * Initialize RotatedBoxes and QuadriBoxes * Move all box modes into Structures, Add docstring * Update docstring * Upload UT * Fix comments * Update inplace operations * Update * Update * Update * Update * Updata rotate and project UT * Update * Update * Update * Update * update * Update from_instance_masks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Add RotatedBoxes and QuadriBoxes data structure in mmrotate.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist