[Fix] confusion_matrix.py arguments not working / crashing the script. #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Removed invalid `score_threshold` arg in `nms_rotated` call 2. Passed `--color-theme` to `plot_confusion_matrix`
k-papadakis
force-pushed
the
fix/confmat
branch
from
63265fb to
6b5e3c4
Compare
k-papadakis
changed the title
zytx121
previously approved these changes
Oct 1, 2022
RangiLyu
approved these changes
Oct 11, 2022
triple-Mu
pushed a commit
to triple-Mu/mmrotate
that referenced
this pull request
Jan 31, 2023
1. Removed invalid `score_threshold` arg in `nms_rotated` call 2. Passed `--color-theme` to `plot_confusion_matrix`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
score_thresholdarg innms_rotatedcall--color-themetoplot_confusion_matrixMotivation
This PR aims to fix a non-working
--color-themecommand line argument and to prevent the script from crashing whenever--nms-iou-thris specified.Modification
The non-working
--color-themeargument is now passed to theplot_confusion_matrixcall.The
--nms-iou-thris fixed by removing an invalidscore_thresholdargument in annms_rotatedcall.