Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify keys in dataset.metainfo to lower case. #654

Merged
merged 2 commits into from
Dec 30, 2022

Conversation

zytx121
Copy link
Collaborator

@zytx121 zytx121 commented Dec 6, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Modify keys in dataset.metainfo to lower case.
CLASSES -> classes
PLATTE -> platte

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. The documentation has been modified accordingly, like docstring or example tutorials.

@yangxue0827
Copy link
Collaborator

This PR needs to be merged after h2rbox, since h2rbox modified dota.py to support dota1.5 and dota2.0.

@CLAassistant
Copy link

CLAassistant commented Dec 14, 2022

CLA assistant check
All committers have signed the CLA.

@zytx121 zytx121 requested a review from yangxue0827 December 14, 2022 08:55
@zytx121 zytx121 mentioned this pull request Dec 30, 2022
@RangiLyu RangiLyu merged commit c404050 into open-mmlab:dev-1.x Dec 30, 2022
triple-Mu pushed a commit to triple-Mu/mmrotate that referenced this pull request Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants