Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeCamp #38 RTMDet-R #662

Merged
merged 57 commits into from
Dec 19, 2022
Merged

CodeCamp #38 RTMDet-R #662

merged 57 commits into from
Dec 19, 2022

Conversation

liuyanyi
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Dec 16, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@zytx121 zytx121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zytx121 zytx121 requested a review from RangiLyu December 16, 2022 14:34
@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Base: 61.87% // Head: 79.62% // Increases project coverage by +17.75% 🎉

Coverage data is based on head (2341566) compared to base (529fb00).
Patch coverage: 66.56% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##           dev-1.x     #662       +/-   ##
============================================
+ Coverage    61.87%   79.62%   +17.75%     
============================================
  Files           99      100        +1     
  Lines         6908     7239      +331     
  Branches       977     1039       +62     
============================================
+ Hits          4274     5764     +1490     
+ Misses        2405     1137     -1268     
- Partials       229      338      +109     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmrotate/models/losses/gaussian_dist_loss.py 85.15% <33.33%> (-1.36%) ⬇️
mmrotate/models/losses/gaussian_dist_loss_v1.py 87.61% <33.33%> (-1.71%) ⬇️
mmrotate/models/dense_heads/rotated_rtmdet_head.py 64.85% <64.85%> (ø)
mmrotate/models/dense_heads/__init__.py 100.00% <100.00%> (ø)
.../task_modules/coders/distance_angle_point_coder.py 53.84% <100.00%> (ø)
mmrotate/structures/bbox/__init__.py 100.00% <100.00%> (ø)
mmrotate/structures/bbox/transforms.py 40.00% <100.00%> (+16.74%) ⬆️
mmrotate/visualization/local_visualizer.py 87.50% <100.00%> (+0.19%) ⬆️
mmrotate/evaluation/metrics/dota_metric.py 87.00% <0.00%> (-1.13%) ⬇️
mmrotate/models/task_modules/coders/angle_coder.py 44.55% <0.00%> (+0.99%) ⬆️
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@RangiLyu RangiLyu merged commit 447b30d into open-mmlab:dev-1.x Dec 19, 2022
@zytx121 zytx121 mentioned this pull request Dec 30, 2022
triple-Mu pushed a commit to triple-Mu/mmrotate that referenced this pull request Jan 31, 2023
* Add DistributionAngleCoder

* fix keepdim

* rtm init

* fix distribution angle coder

* clean

* clean

* add probiou

* add hrsc cfg

* fix GDLoss with empty input

* add probiou cfg

* add mixup mosaic cfg

* Add DistributionAngleCoder

* fix keepdim

* rtm init

* fix distribution angle coder

* clean

* clean

* add probiou

* add hrsc cfg

* fix GDLoss with empty input

* add probiou cfg

* add mixup mosaic cfg

* fix mmdeploy vis error

* add function_rewriter for deploy

* fix hrsc config

* remove deploy

* move distance2obb to transforms, remove useless code

* refactor configs

* fix readme

* fix readme

* clean

* add docstring

* add unittest

* update metafile

* remove useless code

* add img height

* typo

* update results

* fix table

* optimize tables

* add

* fix config

* upload

* update pth link

* add readme pth

* update readme

* update readme

* remove useless cfg

* fix ut on cpu

* fix comment

* add comment for change

* add cite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants