Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Deprecating old type alias due to new version of numpy #674

Merged
merged 2 commits into from
Dec 30, 2022
Merged

[Fix] Deprecating old type alias due to new version of numpy #674

merged 2 commits into from
Dec 30, 2022

Conversation

RangeKing
Copy link
Contributor

Motivation

Deprecating old type alias due to new version of numpy.

Modification

  1. Replace the np.int with np.int32.
  2. Replace all np.bool with bool.

zytx121
zytx121 approved these changes Dec 29, 2022
View reviewed changes
Copy link
Collaborator

@zytx121 zytx121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RangiLyu RangiLyu merged commit b88863d into open-mmlab:dev-1.x Dec 30, 2022
@zytx121 zytx121 mentioned this pull request Dec 30, 2022
Merged
@RangeKing RangeKing deleted the new_type_alias branch December 30, 2022 10:50
triple-Mu pushed a commit to triple-Mu/mmrotate that referenced this pull request Jan 31, 2023
@RangeKing @triple-Mu
[Fix] Deprecating old type alias due to new version of numpy (open-mm…
862f6a5 
…lab#674)

* deprecating `np.int` type alias

* deprecating `np.bool` type alias
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zytx121 zytx121 zytx121 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RangeKing @zytx121 @RangiLyu