-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set e2cnn
as an optional dependency
#724
Conversation
e2cnn
as optional dependencye2cnn
as an optional dependency
Codecov ReportBase: 61.90% // Head: 79.37% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev-1.x #724 +/- ##
============================================
+ Coverage 61.90% 79.37% +17.47%
============================================
Files 100 100
Lines 7239 7272 +33
Branches 1039 1039
============================================
+ Hits 4481 5772 +1291
+ Misses 2507 1162 -1345
- Partials 251 338 +87
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The latest e2cnn has supported the new numpy version. You can upgrade the requirement file like this https://github.com/open-mmlab/mmrotate/pull/713/files |
Done. |
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
open-mmlab/mmyolo#513
e2cnn
, so we set it as an optional dependency.Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist