Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] File I/O migration and reconstruction #783

Merged
merged 4 commits into from
Mar 28, 2023

Conversation

zytx121
Copy link
Collaborator

@zytx121 zytx121 commented Mar 22, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Refer to open-mmlab/mmdetection#9709.
MMCV >= 2.0.0rc4
MMEngine >= 0.6.0
MMDetection>=3.0.0rc6

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Patch coverage: 64.70% and project coverage change: +17.60 🎉

Comparison is base (c1aa0f9) 61.68% compared to head (a41a3fa) 79.28%.

Additional details and impacted files
@@             Coverage Diff              @@
##           dev-1.x     #783       +/-   ##
============================================
+ Coverage    61.68%   79.28%   +17.60%     
============================================
  Files          100      100               
  Lines         7269     7271        +2     
  Branches      1040     1042        +2     
============================================
+ Hits          4484     5765     +1281     
+ Misses        2534     1166     -1368     
- Partials       251      340       +89     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmrotate/datasets/dior.py 74.50% <57.14%> (-1.73%) ⬇️
mmrotate/datasets/hrsc.py 81.81% <57.14%> (-1.67%) ⬇️
mmrotate/__init__.py 100.00% <100.00%> (ø)

... and 30 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zytx121 zytx121 requested review from liuyanyi and RangiLyu March 22, 2023 06:42
@@ -6,7 +6,7 @@

from .version import __version__, short_version

mmcv_minimum_version = '2.0.0rc2'
mmcv_minimum_version = '2.0.0rc4'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RangiLyu RangiLyu merged commit d92844a into open-mmlab:dev-1.x Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants