Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix confusion_matrix #870

Merged
merged 2 commits into from
Jun 12, 2023
Merged

Conversation

liuyanyi
Copy link
Collaborator

@liuyanyi liuyanyi commented Jun 7, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

#869

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. The documentation has been modified accordingly, like docstring or example tutorials.

Copy link
Collaborator

@zytx121 zytx121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RangiLyu RangiLyu merged commit a860946 into open-mmlab:dev-1.x Jun 12, 2023
@notbug1024
Copy link

Hello, when I used a data set in dota format to experiment with rotating frames, I encountered the same problem as the #869 , but I solved it according to the method provided below.

However, when I experimented with the coco format data set, an error still occurred. The specific error information is as follows. How should I solve it? Thanks.

File "/mnt/chen2t/mmrotate-1.0.0rc1/tools/analysis_tools/confusion_matrix_modify.py", line 276, in
main()
File "/mnt/chen2t/mmrotate-1.0.0rc1/tools/analysis_tools/confusion_matrix_modify.py", line 263, in main
confusion_matrix = calculate_confusion_matrix(dataset, results,
File "/mnt/chen2t/mmrotate-1.0.0rc1/tools/analysis_tools/confusion_matrix_modify.py", line 88, in calculate_confusion_matrix
analyze_per_img_dets(confusion_matrix, gts, res_bboxes, score_thr,
File "/mnt/chen2t/mmrotate-1.0.0rc1/tools/analysis_tools/confusion_matrix_modify.py", line 129, in analyze_per_img_dets
gt_bboxes = qbox2rbox(gt_bboxes)
File "/mnt/chen2t/mmrotate-1.0.0rc1/mmrotate/structures/bbox/box_converters.py", line 109, in qbox2rbox
points = boxes.cpu().numpy().reshape(-1, 4, 2)
ValueError: cannot reshape array of size 4 into shape (4,2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants