-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#54 Added support for the Gatekeeper External Data Provider #55
#54 Added support for the Gatekeeper External Data Provider #55
Conversation
750c65b
to
334c65a
Compare
Thanks for the PR @bdun1013
|
42dd0a7
to
9487d8a
Compare
Codecov ReportBase: 54.19% // Head: 53.96% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #55 +/- ##
==========================================
- Coverage 54.19% 53.96% -0.24%
==========================================
Files 1 1
Lines 393 404 +11
==========================================
+ Hits 213 218 +5
- Misses 118 121 +3
- Partials 62 65 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
9487d8a
to
42e6327
Compare
@ritazh @maxsmythe I updated dependencies and the tests are now passing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…rovider Signed-off-by: Brian Dunnigan <bdunnigan@clarityinnovates.com>
42e6327
to
a608fac
Compare
@ritazh Are you able to merge and release 0.7? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one comment about how we may want to eventually make the watch/update loop generic if we keep adding kinds.
@ritazh @maxsmythe I am unable to merge. Would one of you mind merging and releasing v0.7.0? Thanks! |
Signed-off-by: bdunnigan bdunnigan@clarityinnovates.com
Fixes #54