Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#54 Added support for the Gatekeeper External Data Provider #55

Conversation

bdun1013
Copy link
Contributor

@bdun1013 bdun1013 commented Jan 20, 2023

Signed-off-by: bdunnigan bdunnigan@clarityinnovates.com

Fixes #54

@bdun1013 bdun1013 force-pushed the 54-gatekeeper-external-data-provider-support branch from 750c65b to 334c65a Compare January 20, 2023 21:01
@ritazh
Copy link
Member

ritazh commented Jan 21, 2023

Thanks for the PR @bdun1013

--- FAIL: TestReconcileWebhook (3.72s)
--- FAIL: TestReconcileWebhook/externaldataprovider (0.05s)
rotator_test.go:222:
creating webhookConfig
Unexpected error:
<*meta.NoKindMatchError | 0xc000a9a080>: {
GroupKind: {
Group: "externaldata.gatekeeper.sh",
Kind: "Provider",
},
SearchedVersions: ["v1beta1"],
}
no matches for kind "Provider" in version "externaldata.gatekeeper.sh/v1beta1"
occurred
FAIL

@bdun1013 bdun1013 force-pushed the 54-gatekeeper-external-data-provider-support branch 2 times, most recently from 42dd0a7 to 9487d8a Compare February 2, 2023 20:45
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2023

Codecov Report

Base: 54.19% // Head: 53.96% // Decreases project coverage by -0.24% ⚠️

Coverage data is based on head (42e6327) compared to base (71c4f4e).
Patch coverage: 56.25% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
- Coverage   54.19%   53.96%   -0.24%     
==========================================
  Files           1        1              
  Lines         393      404      +11     
==========================================
+ Hits          213      218       +5     
- Misses        118      121       +3     
- Partials       62       65       +3     
Flag Coverage Δ
unittests 53.96% <56.25%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/rotator/rotator.go 53.96% <56.25%> (-0.24%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdun1013 bdun1013 force-pushed the 54-gatekeeper-external-data-provider-support branch from 9487d8a to 42e6327 Compare February 2, 2023 20:54
@bdun1013
Copy link
Contributor Author

bdun1013 commented Feb 2, 2023

@ritazh @maxsmythe I updated dependencies and the tests are now passing

Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…rovider

Signed-off-by: Brian Dunnigan <bdunnigan@clarityinnovates.com>
@bdun1013 bdun1013 force-pushed the 54-gatekeeper-external-data-provider-support branch from 42e6327 to a608fac Compare February 3, 2023 15:15
@bdun1013
Copy link
Contributor Author

bdun1013 commented Feb 9, 2023

@ritazh Are you able to merge and release 0.7?

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one comment about how we may want to eventually make the watch/update loop generic if we keep adding kinds.

@bdun1013
Copy link
Contributor Author

@ritazh @maxsmythe I am unable to merge. Would one of you mind merging and releasing v0.7.0? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for the Gatekeeper External Data Provider
4 participants