Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly fetching fetching git tags for CI builds #7395

Merged
merged 3 commits into from
Feb 27, 2025
Merged

Explicitly fetching fetching git tags for CI builds #7395

merged 3 commits into from
Feb 27, 2025

Conversation

johanfylling
Copy link
Contributor

An attempt to deal with failing nightly Trivy scans.

@johanfylling
Explicitly fetching fetching git tags for CI builds
6d5ec25 
Signed-off-by: Johan Fylling <johan.dev@fylling.se>
@johanfylling
Copy link
Contributor Author

This is likely not the solution

@johanfylling
Updating what jobs we pull tags for
9faf570 
Signed-off-by: Johan Fylling <johan.dev@fylling.se>
@johanfylling
Copy link
Contributor Author

Let's give it a shot

@johanfylling johanfylling reopened this Feb 27, 2025
charlieegan3
charlieegan3 approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@charlieegan3 charlieegan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if we can use fetch-tags on the checkout step that'd be nice too. Hopefully this means the go builds will set the versions correctly.

@johanfylling
Using fetch-tags
1f62971 
Signed-off-by: Johan Fylling <johan.dev@fylling.se>
@johanfylling johanfylling merged commit 10d1a54 into open-policy-agent:main Feb 27, 2025
28 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Feb 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlieegan3 charlieegan3 charlieegan3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johanfylling @charlieegan3