Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add note about v1.0 addr behaviour #7398

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

charlieegan3
Copy link
Contributor

Copy link

netlify bot commented Feb 27, 2025

Deploy Preview for openpolicyagent ready!

Name Link
🔨 Latest commit 567f579
🔍 Latest deploy log https://app.netlify.com/sites/openpolicyagent/deploys/67c0743bc547e5000955b111
😎 Deploy Preview https://deploy-preview-7398--openpolicyagent.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

it's good practice to bind OPA to localhost by default if OPA is not intended to
be exposed to remote services.

If you need to replicate the v0.x behaviour, you can use the `--addr` flag to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps worth explicitly calling out that this is likely necessary when running OPA in Docker?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've added an info block for that now

Copy link
Contributor

@srenatus srenatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick aside, lgtm

in other environments.

More information can be found in the
[security documentation](https://www.openpolicyagent.org/docs/latest/security/#interface-binding).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] Should this be a relevant....no, a relative link? Or can't we do that with # anchors? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's fair, I have updated.

@charlieegan3 charlieegan3 merged commit 85eaacd into open-policy-agent:main Feb 27, 2025
28 checks passed
charlieegan3 added a commit to charlieegan3/opa-envoy-plugin that referenced this pull request Mar 5, 2025
anderseknert pushed a commit to open-policy-agent/opa-envoy-plugin that referenced this pull request Mar 5, 2025
https://github.com/orgs/open-policy-agent/discussions/671

open-policy-agent/opa#7398

Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>
Co-authored-by: Charlie Egan <charlieegan3@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Add --addr cmd argument in documentations
3 participants