-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add note about v1.0 addr behaviour #7398
Conversation
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
it's good practice to bind OPA to localhost by default if OPA is not intended to | ||
be exposed to remote services. | ||
|
||
If you need to replicate the v0.x behaviour, you can use the `--addr` flag to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps worth explicitly calling out that this is likely necessary when running OPA in Docker?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I've added an info block for that now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick aside, lgtm
docs/content/deployments.md
Outdated
in other environments. | ||
|
||
More information can be found in the | ||
[security documentation](https://www.openpolicyagent.org/docs/latest/security/#interface-binding). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit] Should this be a relevant....no, a relative link? Or can't we do that with #
anchors? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that's fair, I have updated.
6ac6fde
to
9edce11
Compare
Fixes open-policy-agent#7360 Also https://github.com/orgs/open-policy-agent/discussions/662#discussioncomment-12338962t Signed-off-by: Charlie Egan <charlie@styra.com>
9edce11
to
567f579
Compare
https://github.com/orgs/open-policy-agent/discussions/671 open-policy-agent/opa#7398 Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>
https://github.com/orgs/open-policy-agent/discussions/671 open-policy-agent/opa#7398 Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com> Co-authored-by: Charlie Egan <charlieegan3@users.noreply.github.com>
Fixes #7360
Also https://github.com/orgs/open-policy-agent/discussions/662#discussioncomment-12338962